minor changes to randmatmul that yield major speed-ups #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Total time has been reduced by around 65 to 75%. The biggest improvement was in matmul, where it was accessing the array on every iteration whilst summing. Now it sums in a 'total' variable, and the array is set once. This alone removed over 65% of the time. I also moved to using Float64Arrays for matmul, which yields a minor improvement.
JeffBezanson
added a commit
that referenced
this pull request
Feb 20, 2012
minor changes to randmatmul that yield major speed-ups
StefanKarpinski
pushed a commit
that referenced
this pull request
Feb 8, 2018
character and string concatenation
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Oct 11, 2021
cmcaine
pushed a commit
to cmcaine/julia
that referenced
this pull request
Nov 11, 2022
* Define repo-specific labels. This commit adds a `.appends/.github/labels.yml` file, which contains the repo-specific labels. This file will automatically be combined with the Exercism-wide labels defined in https://github.com/exercism/org-wide-files/blob/main/global-files/.github/labels.yml to form the `.github/labels.yml` file. * Define the labels used in this repo. This commit adds a `.github/labels.yml` file, which contains the full list of labels that this repo can use. This file is a combination of the `.appends/.github/labels.yml` file and the Exercism-wide labels defined in https://github.com/exercism/org-wide-files/blob/main/global-files/.github/labels.yml. * Add a GitHub Actions workflow to automatically sync the repository labels. This commit adds a `.github/workflow/sync-labels.yml` file, which defines a workflow that syncs this repository's labels with the contents of the `.github/labels.yml` file. The labels are synced automatically whenever the `.github/labels.yml` file changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total time has been reduced by around 65 to 75%.
The biggest improvement was in matmul, where it was previously adding to the array whilst summing up a series of values. Now it sums using a 'total' variable, with the array being updated at the end. This alone removed over 65% of the time.
I also moved to using Float64Arrays for matmul, which adds a little more speed.